svn commit: r347120 - stable/12/sys/netinet

[Michael Tuexen]

Author: tuexen
Date: Sat May  4 12:57:55 2019
New Revision: 347120
URL: https://svnweb.freebsd.org/changeset/base/347120

Log:
  MFC r345525:
  Fix a double free of an SCTP association in an error path.
  This is joint work with rrs at . The issue was found by running
  syzkaller.

Modified:
  stable/12/sys/netinet/sctp_usrreq.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/netinet/sctp_usrreq.c
==============================================================================
--- stable/12/sys/netinet/sctp_usrreq.c	Sat May  4 12:56:09 2019	(r347119)
+++ stable/12/sys/netinet/sctp_usrreq.c	Sat May  4 12:57:55 2019	(r347120)
@@ -1481,8 +1481,6 @@ sctp_do_connect_x(struct socket *so, struct sctp_inpcb
 	sctp_connectx_helper_add(stcb, sa, (totaddr - 1), &error);
 	/* Fill in the return id */
 	if (error) {
-		(void)sctp_free_assoc(inp, stcb, SCTP_PCBFREE_FORCE,
-		    SCTP_FROM_SCTP_USRREQ + SCTP_LOC_7);
 		goto out_now;
 	}
 	a_id = (sctp_assoc_t *)optval;