svn commit: r347092 - stable/12/sys/netinet

[Michael Tuexen]

Author: tuexen
Date: Sat May  4 10:09:25 2019
New Revision: 347092
URL: https://svnweb.freebsd.org/changeset/base/347092

Log:
  MFC r343961:
  Fix a locking issue when reporing outbound messages.

Modified:
  stable/12/sys/netinet/sctputil.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/netinet/sctputil.c
==============================================================================
--- stable/12/sys/netinet/sctputil.c	Sat May  4 10:06:17 2019	(r347091)
+++ stable/12/sys/netinet/sctputil.c	Sat May  4 10:09:25 2019	(r347092)
@@ -3946,7 +3946,7 @@ sctp_report_all_outbound(struct sctp_tcb *stcb, uint16
 		TAILQ_FOREACH_SAFE(sp, &outs->outqueue, next, nsp) {
 			atomic_subtract_int(&asoc->stream_queue_cnt, 1);
 			TAILQ_REMOVE(&outs->outqueue, sp, next);
-			stcb->asoc.ss_functions.sctp_ss_remove_from_stream(stcb, asoc, outs, sp, holds_lock);
+			stcb->asoc.ss_functions.sctp_ss_remove_from_stream(stcb, asoc, outs, sp, 1);
 			sctp_free_spbufspace(stcb, asoc, sp);
 			if (sp->data) {
 				sctp_ulp_notify(SCTP_NOTIFY_SPECIAL_SP_FAIL, stcb,