svn commit: r347086 - stable/12/sys/netinet

[Michael Tuexen]

Author: tuexen
Date: Sat May  4 09:25:32 2019
New Revision: 347086
URL: https://svnweb.freebsd.org/changeset/base/347086

Log:
  MFC r343951:
  Fix locking for IPPROTO_SCTP level SCTP_DEFAULT_PRINFO socket option.
  This problem occurred when calling setsockopt() will invalid parameters.
  
  This issue was found by running syzkaller.

Modified:
  stable/12/sys/netinet/sctp_usrreq.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/netinet/sctp_usrreq.c
==============================================================================
--- stable/12/sys/netinet/sctp_usrreq.c	Sat May  4 09:18:19 2019	(r347085)
+++ stable/12/sys/netinet/sctp_usrreq.c	Sat May  4 09:25:32 2019	(r347086)
@@ -6209,6 +6209,9 @@ sctp_setopt(struct socket *so, int optname, void *optv
 			SCTP_FIND_STCB(inp, stcb, info->pr_assoc_id);
 
 			if (info->pr_policy > SCTP_PR_SCTP_MAX) {
+				if (stcb) {
+					SCTP_TCB_UNLOCK(stcb);
+				}
 				SCTP_LTRACE_ERR_RET(inp, NULL, NULL, SCTP_FROM_SCTP_USRREQ, EINVAL);
 				error = EINVAL;
 				break;