svn commit: r345625 - in head: contrib/elftoolchain/readelf lib/libc lib/libthr libexec/rtld-elf sys/sys

[Renato Botelho]

On 3/28/19 4:25 AM, Oliver Pinter wrote:
> On Thursday, March 28, 2019, Ed Maste <emaste at freebsd.org> wrote:
>
>> Author: emaste
>> Date: Thu Mar 28 02:12:32 2019
>> New Revision: 345625
>> URL: https://svnweb.freebsd.org/changeset/base/345625
>>
>> Log:
>>   revert r341429 "disable BIND_NOW in libc, libthr, and rtld"
>>
>>   r345620 by kib@ fixed the rtld issue that caused a crash at startup
>>   during resolution of libc's ifuncs with BIND_NOW.
>>
>>   PR:           233333
>>   Sponsored by: The FreeBSD Foundation
>>
>> Modified:
>>   head/contrib/elftoolchain/readelf/readelf.c
>>   head/lib/libc/Makefile
>>   head/lib/libthr/Makefile
>>   head/libexec/rtld-elf/Makefile
>>   head/sys/sys/elf_common.h
>>
>> Modified: head/contrib/elftoolchain/readelf/readelf.c
>> ============================================================
>> ==================
>> --- head/contrib/elftoolchain/readelf/readelf.c Thu Mar 28 01:12:44 2019
>>       (r345624)
>> +++ head/contrib/elftoolchain/readelf/readelf.c Thu Mar 28 02:12:32 2019
>>       (r345625)
>> @@ -3490,6 +3490,7 @@ dump_notes(struct readelf *re)
>>
>>  static struct flag_desc note_feature_ctl_flags[] = {
>>         { NT_FREEBSD_FCTL_ASLR_DISABLE,         "ASLR_DISABLE" },
>> +       { NT_FREEBSD_FCTL_IMPLIED_MAX_PROT,     "IMPLIED_MAX_PROT" },
>>         { 0, NULL }
>>  };
>>
>>
> Seems like this and the other hunk belongs to a different patch.
Indeed. It broke the build for me

-- 
Renato Botelho