svn commit: r345400 - in head/libexec/rc: . rc.d

[Cy Schubert]

In message <201903220517.x2M5HBqg063638 at gndrsh.dnsmgr.net>, "Rodney W. 
Grimes"
writes:
> > Author: cy
> > Date: Fri Mar 22 01:30:51 2019
> > New Revision: 345400
> > URL: https://svnweb.freebsd.org/changeset/base/345400
> > 
> > Log:
> >   Add rc.d support for ippool(8).
> >   
> >   I've been using ippool at my site for approximately two years. It's
> >   about time this was committed.
> >   
> >   PR:		218433
> >   MFC after:	2 weeks
> > 
> > Added:
> >   head/libexec/rc/rc.d/ippool   (contents, props changed)
> > Modified:
> >   head/libexec/rc/rc.conf
> > 
> > Modified: head/libexec/rc/rc.conf
> > ===========================================================================
> ===
> > --- head/libexec/rc/rc.conf	Thu Mar 21 23:31:10 2019	(r345399)
> > +++ head/libexec/rc/rc.conf	Fri Mar 22 01:30:51 2019	(r345400)
> > @@ -196,6 +196,10 @@ ipfilter_program="/sbin/ipf"	# where the ipfilter pr
> og
> >  ipfilter_rules="/etc/ipf.rules"	# rules definition file for ipfilter, s
> ee
> >  				# /usr/src/contrib/ipfilter/rules for examples
> >  ipfilter_flags=""		# additional flags for ipfilter
> > +ippool_enable="NO"		# Set to YES to enable ip filter pools
> > +ippool_program="/sbin/ippool"	# where the ippool program lives
> > +ippool_rules="/etc/ippool.tables"	# rules definition file for ippool
> > +ippool_flags=""			# additional flags for ippool
> >  ipnat_enable="NO"		# Set to YES to enable ipnat functionality
> >  ipnat_program="/sbin/ipnat"	# where the ipnat program lives
> >  ipnat_rules="/etc/ipnat.rules"	# rules definition file for ipnat
> > 
> > Added: head/libexec/rc/rc.d/ippool
> > ===========================================================================
> ===
> > --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> > +++ head/libexec/rc/rc.d/ippool	Fri Mar 22 01:30:51 2019	(r34540
> 0)
> > @@ -0,0 +1,40 @@
> > +#!/bin/sh
> > +#
> > +# $FreeBSD$
> > +#
> > +
> > +# PROVIDE: ippool
> > +# REQUIRE: FILESYSTEMS
> > +# BEFORE:  ipfilter
> > +# KEYWORD: nojail
> > +
> > +. /etc/rc.subr
> > +
> > +name="ippool"
> > +desc="user interface to the IPFilter pools"
> > +rcvar="ippool_enable"
> > +load_rc_config $name
> > +start_cmd="ippool_start"
> > +stop_cmd="${ippool_program} -F"
> > +reload_cmd="ippool_reload"
> > +extra_commands="reload"
> > +required_files="${ippool_rules}"
> > +required_modules="ipl:ipfilter"
> > +
> > +ippool_start()
> > +{
> > +	if [ -r "${ippool_rules}" ]; then
> > +		echo "Loading IP Pools."
> > +		${ippool_program} -f ${ippool_rules} ${ippool_flags}
> > +	fi
> > +}
> > +
> > +ippool_reload()
> > +{
> > +	echo "Reloading IP Pools."
> > +	${ippool_program} -F
> > +	ippool_start
>
> Couldnt this better be expressed
> 	${stop_cmd}
> 	${start_cmd}
>

Yes. I'll fix that.

> > +}
> > +
> > +
> > +run_rc_command "$1"
> > 
> > 
>
> -- 
> Rod Grimes                                                 rgrimes at freebsd.or
> g
>



-- 
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.