svn commit: r345171 - head/usr.sbin/bhyve

[Warner Losh]

On Fri, Mar 15, 2019 at 11:27 AM Rodney W. Grimes <freebsd at gndrsh.dnsmgr.net>
wrote:

> > On Fri, Mar 15, 2019 at 9:56 AM Rodney W. Grimes <
> freebsd at gndrsh.dnsmgr.net>
> > wrote:
> >
> > > > On Thu, Mar 14, 2019 at 8:32 PM Rodney W. Grimes <
> > > freebsd at gndrsh.dnsmgr.net>
> > > > wrote:
> > > >
> > > > > > Author: chuck
> > > > > > Date: Fri Mar 15 02:11:28 2019
> > > > > > New Revision: 345171
> > > > > > URL: https://svnweb.freebsd.org/changeset/base/345171
> > > > > >
> > > > > > Log:
> > > > > >   Fix bhyve PCIe capability emulation
> > > > > >
> > > > > >   PCIe devices starting with version 1.1 must set the Role-Based
> > > Error
> > > > > >   Reporting bit.
> > > > > >
> > > > > >   And while we're in the neighborhood, generalize the code
> assigning
> > > the
> > > > > >   device type.
> > > > > >
> > > > > >   Reviewed by:        imp, araujo, rgrimes
> > > > > >   Approved by:        imp (mentor)
> > > > > >   MFC after:  1 week
> > > > > >   Differential Revision: https://reviews.freebsd.org/D19580
> > > > >
> > > > > This code requires maintainer approval before a commit,
> > > > > though this was well reviewed that doesnt exclude it
> > > > > from the MAINTAINERS entry.
> > > > >
> > > > > Leave it for now, I am sure jhb or thyco are fine with it,
> > > > > this is just a heads up FYI for future commits.
> > > > >
> > > > > Bhyve code has been and still is under a fairly tight
> > > > > MAINTAINER status.
> > > > >
> > > >
> > > > There is no such thing as a hard lock in FreeBSD. This sounds like
> you
> > > are
> > > > advocating for that, but that's not the case.
> > > >
> > > > Stop this stupid nitpicking for single line commits. We don't have
> that
>                 ^^^^^^
>
> Thank you for calling my actions stupid, in effect demoralizing me with
> the label that includes.  I may nit pick, but I never call people degrading
> names on a public list.


I said your actions (specifically the nitpicking) were stupid. I never
called you stupid, and don't think you are stupid.

Warner