svn commit: r345025 - head/sys/cam/scsi

[Warner Losh]

Author: imp
Date: Mon Mar 11 20:57:54 2019
New Revision: 345025
URL: https://svnweb.freebsd.org/changeset/base/345025

Log:
  Upgrade Chipfancier SLC quirk to all versions
  
  The 16GB, 32GB and 128GB versions of this product all have the same
  problem. For some reason, the RC10 size is correct, while the RC16
  size is larger (oddly by the capacity size / 1024 bytes). Using the
  RC16 size results in illegal LBA range errors when geom tastes the
  device. So, expand the quirk to cover all versions of this chip.
  
  Ideally, we'd get both READ CAPACITY 10 and READ CAPACITY 16 sizes and
  print a warnnig if they differ and use the smaller of the two numbers,
  though that may be problematical as well. Furthermore, SBC-4
  encourages users transition to RC16 only, which suggests that in the
  future RC10 may disappear from some drives. It's unclear how to cope
  with these drives generically.
  
  PR: 234503
  MFC After: 1 week

Modified:
  head/sys/cam/scsi/scsi_da.c

Modified: head/sys/cam/scsi/scsi_da.c
==============================================================================
--- head/sys/cam/scsi/scsi_da.c	Mon Mar 11 20:40:56 2019	(r345024)
+++ head/sys/cam/scsi/scsi_da.c	Mon Mar 11 20:57:54 2019	(r345025)
@@ -865,11 +865,12 @@ static struct da_quirk_entry da_quirk_table[] =
 	},
 	{
 		/*
-		 * 16GB SLC CHIPFANCIER
-		 * PR: usb/234503
+		 * SLC CHIPFANCIER USB drives
+		 * PR: usb/234503 (RC10 right, RC16 wrong)
+		 * 16GB, 32GB and 128GB confirmed to have same issue
 		 */
-		{T_DIRECT, SIP_MEDIA_REMOVABLE, "16G SLC", "CHIPFANCIER",
-		 "1.00"}, /*quirks*/ DA_Q_NO_RC16
+		{T_DIRECT, SIP_MEDIA_REMOVABLE, "*SLC", "CHIPFANCIER",
+		 "*"}, /*quirks*/ DA_Q_NO_RC16
        },
 	/* ATA/SATA devices over SAS/USB/... */
 	{