svn commit: r344701 - head/sbin/camcontrol

Cy Schubert Cy.Schubert at cschubert.com
Sun Mar 3 21:42:21 UTC 2019


In message <06d7e6402ad6f673b15873a9d99c9382f21e64b9.camel at freebsd.org>
, Ian Le
pore writes:
> On Sun, 2019-03-03 at 12:20 -0800, Enji Cooper wrote:
> > > On Mar 3, 2019, at 11:12, Steven Hartland <steven at multiplay.co.uk>
> > > wrote:
> > > 
> > > Not really much more to say that isn't explained by that and the
> > > code.
> > > 
> > > Sure I could have used a different sentence structure for the body
> > > but it wouldn't add anything IMO, thoughts?
> > 
> >     Why the previous sector size was wrong isn’t clear from the
> > commit message. Why switch from a sizeof to 0?
> > Cheers!
> > -Enji
> > 
>
> The commit message said it was "incorrect / unused". While a bit terse,
> it does communicate that the old value was incorrect (by being there at
> all) because the value is unused (so zero more clearly expresses that).
>
> It's not completely a joke that most English-speaking software
> engineers have English as a second language. :)

This is one of those profound quotes that should be in fortune(1).


-- 
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.




More information about the svn-src-all mailing list