svn commit: r344736 - head/sys/dev/nvme

Warner Losh imp at FreeBSD.org
Sun Mar 3 03:36:35 UTC 2019


Author: imp
Date: Sun Mar  3 03:36:33 2019
New Revision: 344736
URL: https://svnweb.freebsd.org/changeset/base/344736

Log:
  Add ABORTED_BY_REQUEST to the list of things we look at DNR bit and tell why to comment (code already does this)

Modified:
  head/sys/dev/nvme/nvme_qpair.c

Modified: head/sys/dev/nvme/nvme_qpair.c
==============================================================================
--- head/sys/dev/nvme/nvme_qpair.c	Sun Mar  3 03:09:43 2019	(r344735)
+++ head/sys/dev/nvme/nvme_qpair.c	Sun Mar  3 03:36:33 2019	(r344736)
@@ -331,7 +331,8 @@ nvme_completion_is_retry(const struct nvme_completion 
 	 * TODO: spec is not clear how commands that are aborted due
 	 *  to TLER will be marked.  So for now, it seems
 	 *  NAMESPACE_NOT_READY is the only case where we should
-	 *  look at the DNR bit.
+	 *  look at the DNR bit. Requests failed with ABORTED_BY_REQUEST
+	 *  set the DNR bit correctly since the driver controls that.
 	 */
 	switch (sct) {
 	case NVME_SCT_GENERIC:


More information about the svn-src-all mailing list