svn commit: r349459 - head/sys/sys

[Andriy Gapon]

On 27/06/2019 18:47, Bruce Evans wrote:
> On Thu, 27 Jun 2019, Andriy Gapon wrote:
> 
>> Log:
>>  upgrade the warning printf-s in bus accessors to KASSERT-s
>>
>>  After this change sys/bus.h includes sys/systm.h.
> 
> This is further namespace pollution.  sys/systm.h is a prerequiste for
> all kernel headers except sys/param.h and the headers that that includes,
> since any kernel header (except sys/param.hm etc.) may have inlines which
> use features in systm.h, e.g., KASSERT() or an inline function.

Bruce,

what do you think about amending style(9) to require that if sys/systm.h is to
be included, then it must be included before any other header except for
sys/param.h (and possibly sys/cdefs.h) ?

-- 
Andriy Gapon