svn commit: r349349 - in head/stand: efi/include efi/include/Protocol efi/libefi efi/loader libsa

[Warner Losh]

Hey Rod,

On Mon, Jun 24, 2019 at 7:11 PM Rodney W. Grimes <freebsd at gndrsh.dnsmgr.net>
wrote:

> -- Start of PGP signed section.
> [ Charset UTF-8 unsupported, converting... ]
> > On 2019-06-24 18:45, Rodney W. Grimes wrote:
> >
> > > It sys accompanies, that means not a pointer to....
> > > Hum oh my, what has happend to the disclaimer?
> >
> > Huh. It turns out the _latest_ version of that file just contains:
> >
> > /** @file
> >   This file defines the EFI HTTP Protocol interface. It is split into
> >   the following two main sections:
> >   HTTP Service Binding Protocol (HTTPSB)
> >   HTTP Protocol (HTTP)
> >
> >   Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<BR>
> >   (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR>
> >   SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> >   @par Revision Reference:
> >   This Protocol is introduced in UEFI Specification 2.5
> >
> > **/
> >
> >
> > I think I should update the copy in the tree with this version, which
> > makes more sense. Do you agree?
>

Rebecca: I think it frankly doesn't matter. There's no need to go fetch a
stone just to keep Rod happy. The version you committed is fine: it is a
verbatim copy of the vendor source at some point in the past. I looked at
and approved that license. This newer one, I'm less sure about, so please
hold off on that.


> If that is how the vendor is distributing it now, yes, that would
> be safer as the above removes the conflict between what the file says
> and what was done.
>
> Please note that -Patent has not been addressed by core@ to my
> knowledge, and that may or may not be an issue.  I shringe when
> I see these clauses being blanket added to software though.
>
>
Again with the scolding?

Rebecca doesn't deserve this level of nit-picking. It is demotivating. She
did a great job getting this code into the tree and you wag your finger at
her for committing code verbatim from the vendor?

It's totally not cool. Please stop this sort of nonsense. The rest of the
project stopped this level of nit-picking back in the 90's when we all
agreed it was counter productive.

Warner