svn commit: r348521 - in head: . etc sys/conf sys/modules usr.bin/login usr.sbin/services_mkdb

[Maxim Sobolev]

On Mon, Jun 3, 2019 at 7:28 AM Enji Cooper <yaneurabeya at gmail.com> wrote:

> Hi Maxim,
>
>
> > Modified: head/Makefile.inc1
> >
> ==============================================================================
> > --- head/Makefile.inc1    Sun Jun  2 22:27:26 2019    (r348520)
> > +++ head/Makefile.inc1    Sun Jun  2 23:38:19 2019    (r348521)
> > @@ -887,8 +887,8 @@ MTREEFLAGS+=    -W
> > INSTALLFLAGS+=    -h sha256
> > .endif
> > .if defined(DB_FROM_SRC) || defined(NO_ROOT)
> > -IMAKE_INSTALL=    INSTALL="install ${INSTALLFLAGS}"
> > -IMAKE_MTREE=    MTREE_CMD="mtree ${MTREEFLAGS}"
> > +IMAKE_INSTALL=    INSTALL="${INSTALL} ${INSTALLFLAGS}"
> > +IMAKE_MTREE=    MTREE_CMD="${MTREE_CMD} ${MTREEFLAGS}"
> > .endif
>
>     Please back out this part of the change as it is unnecessary and adds
> a dependency on sys.mk’s definitions. $PATH should contain, i.e., be
> populated, with these tools when running make installworld. This is part of
> the logic behind how $ITOOLS, etc, works.
>     Thank you very much for your work and the rest of the change though!
>

 Thanks Enji, for a clarification, will do. I still cannot understand why
can't we have those tools being re-defined with top-level make environment?

What I am striving at is being able to do say, make INSTALL="abcd"
installworld. Yes, I understand I can call "abcd" "install" (or make a
symlink to it) and put it into PATH, but there are at least one issue here,
namely what if I need to pass some distinct argument to abcd based on usage
scenario. E.g. make INSTALL="abcd foo" distributiuon. In your case I should
be resorting to setting up some global environment variable and hope it
won't get erased somewhere in the call chain, but that's bit "how you
doing" IMHO. My approach makes certain things so much easier by cutting
those un-neded steps.

At any rate thank for a feedback and some background info, I will do more
work on this. I was thinking more in terms of having some sort of
bsd.bootools.mk where this can be defined in a centralized manner.

-Max