svn commit: r348355 - head/sys/dev/iicbus

[Niclas Zeising]

On 2019-06-03 14:08, Andriy Gapon wrote:
> On 03/06/2019 14:16, Niclas Zeising wrote:
>> Hi!
>> It seems like things broke after all, latest pkg build (on head-amd64) reports
>> this:
>>
>>
>> /wrkdirs/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12bd551/src/dev/drm2/i915/intel_iic.c:570:2:
>> error: implicit declaration of function 'iicbus_set_nostop' is invalid in C99
>> [-Werror,-Wimplicit-function-declaration]
>>          iicbus_set_nostop(idev, true);
>>          ^
>> /wrkdirs/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12bd551/src/dev/drm2/i915/intel_iic.c:570:2:
>> error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
>> 2 errors generated.
>>
>> Full log:
>>
>> http://beefy12.nyi.freebsd.org/data/head-amd64-default/p503023_s348376/logs/drm-legacy-kmod-g20190523.log
> 
> Hi!  Thank you for the report.
> I am going to restore iicbus_set_nostop, but this time as a function that
> modifies iicbus softc (instead of an ivar accessor for the bus).
> I am including a patch that I would like to commit.
> 
> However, for the drm code to request the nostop mode correctly it needs to be
> fixed as well.
> My proposed patch is here: https://github.com/FreeBSDDesktop/drm-legacy/pull/9
> 


Thank you, I will try it out.
Will this break drm-legacy-kmod on 12, which doesn't have the iic bus 
change you proposed?
Regards
-- 
Niclas Zeising