svn commit: r350254 - head/sys/netinet

[Michael Tuexen]

Author: tuexen
Date: Tue Jul 23 18:31:07 2019
New Revision: 350254
URL: https://svnweb.freebsd.org/changeset/base/350254

Log:
  Don't hold a mutex while calling sbwait. This was found by syzkaller.
  
  Submitted by:		rrs@
  Reported by:		markj@
  MFC after:		1 week

Modified:
  head/sys/netinet/sctp_output.c

Modified: head/sys/netinet/sctp_output.c
==============================================================================
--- head/sys/netinet/sctp_output.c	Tue Jul 23 18:14:32 2019	(r350253)
+++ head/sys/netinet/sctp_output.c	Tue Jul 23 18:31:07 2019	(r350254)
@@ -13409,10 +13409,10 @@ skip_preblock:
 					    stcb,
 					    SCTP_OUTPUT_FROM_USR_SEND, SCTP_SO_LOCKED);
 				}
-				if (hold_tcblock == 1) {
-					SCTP_TCB_UNLOCK(stcb);
-					hold_tcblock = 0;
-				}
+			}
+			if (hold_tcblock == 1) {
+				SCTP_TCB_UNLOCK(stcb);
+				hold_tcblock = 0;
 			}
 			SOCKBUF_LOCK(&so->so_snd);
 			/*-