svn commit: r350228 - head/sys/cam/ata

Brooks Davis brooks at FreeBSD.org
Mon Jul 22 21:07:59 UTC 2019


Author: brooks
Date: Mon Jul 22 21:07:58 2019
New Revision: 350228
URL: https://svnweb.freebsd.org/changeset/base/350228

Log:
  ata_xpt: Use the correct union member when accessing valid.
  
  In principle this should not matter as it's a union and they point to
  the same memory location but based on the code above we should be
  accessing .sata and not .ata.
  
  Submitted by:	arichardson
  Reviewed by:	scottl, imp
  Obtained from:	CheriBSD
  MFC after:	1 week
  Sponsored by:	DARPA, AFRL
  Differential Revision:	https://reviews.freebsd.org/D21002

Modified:
  head/sys/cam/ata/ata_xpt.c

Modified: head/sys/cam/ata/ata_xpt.c
==============================================================================
--- head/sys/cam/ata/ata_xpt.c	Mon Jul 22 21:03:52 2019	(r350227)
+++ head/sys/cam/ata/ata_xpt.c	Mon Jul 22 21:07:58 2019	(r350228)
@@ -452,7 +452,7 @@ negotiate:
 			if (cts.xport_specific.ata.valid & CTS_ATA_VALID_MODE)
 				mode = cts.xport_specific.ata.mode;
 		} else {
-			if (cts.xport_specific.ata.valid & CTS_SATA_VALID_MODE)
+			if (cts.xport_specific.sata.valid & CTS_SATA_VALID_MODE)
 				mode = cts.xport_specific.sata.mode;
 		}
 		/* If SIM disagree - renegotiate. */


More information about the svn-src-all mailing list