svn commit: r350049 - head/contrib/amd/amd
John Baldwin
jhb at FreeBSD.org
Tue Jul 16 20:41:13 UTC 2019
On 7/16/19 12:44 PM, Shawn Webb wrote:
> On Tue, Jul 16, 2019 at 04:03:08PM +0000, Brooks Davis wrote:
>> Author: brooks
>> Date: Tue Jul 16 16:03:08 2019
>> New Revision: 350049
>> URL: https://svnweb.freebsd.org/changeset/base/350049
>>
>> Log:
>> Fix two mismatches between function declaration and definition.
>>
>> In both cases, function pointer arguments were inconsistently declared
>> and the result worked because of C's odd rules around function pointer
>> (de)references. With a stricter compiler these fail to compile.
>
> And, with CFI applied to the kernel, would cause a panic. :)
>
> Good catch and thanks for the great work!
How would an incorrect function prototype in userland cause a kernel panic?
--
John Baldwin
More information about the svn-src-all
mailing list