svn commit: r350044 - in stable/12: share/man/man4 sys/dev/gpio
Li-Wen Hsu
lwhsu at freebsd.org
Tue Jul 16 17:36:45 UTC 2019
On Wed, Jul 17, 2019 at 1:29 AM Andriy Gapon <avg at freebsd.org> wrote:
>
> On 16/07/2019 18:52, Andriy Gapon wrote:
> > Author: avg
> > Date: Tue Jul 16 15:52:47 2019
> > New Revision: 350044
> > URL: https://svnweb.freebsd.org/changeset/base/350044
> >
> > Log:
> > MFC r349460: gpiobus: provide a new hint, pin_list
> >
> > "pin_list" allows to specify child pins as a list of pin numbers.
> > Existing hint "pins" serves the same purpose but with a 32-bit wide bit
> > mask. One problem with that is that a controller can have more than 32
> > pins. One example is amdgpio. Also, a list of numbers is a little bit
> > more human friendly than a matching bit mask. As a side note, it seems
> > that in FDT pins are typically specified by their numbers as well.
> >
> > This commit also adds accessors for instance variables (IVARs) that
> > define the child pins. My primary goal is to allow a child to be
> > configured programmatically rather than via hints (assuming that FDT is
> > not supported on a platform). Also, while a child should not care about
> > specific pin numbers that are allocated to it, it could be interested in
> > how many were actually assigned to it.
> >
> > While there, I removed "flags" instance variable. It was unused.
>
> This change (the "flags" removal, specifically) broke build on OFW
> platforms (powerpc).
> I am working on a fix, it should be trivial.
I've merged r349472 and it should be fine now.
Best,
Li-Wen
More information about the svn-src-all
mailing list