svn commit: r349907 - head/sys/netinet/tcp_stacks

[Cy Schubert]

Cy Schubert writes:
> In message <201907110438.x6B4cXX1054795 at repo.freebsd.org>, Randall 
> Stewart writ
> es:
> > Author: rrs
> > Date: Thu Jul 11 04:38:33 2019
> > New Revision: 349907
> > URL: https://svnweb.freebsd.org/changeset/base/349907
> >
> > Log:
> >   Update copyright per JBH's suggestions.. thanks.
> >
> > Modified:
> >   head/sys/netinet/tcp_stacks/rack.c
> >
> > Modified: head/sys/netinet/tcp_stacks/rack.c
> > ===========================================================================
> ==
> > =
> > --- head/sys/netinet/tcp_stacks/rack.c	Thu Jul 11 03:29:25 2019
> > 	(r349906)
> > +++ head/sys/netinet/tcp_stacks/rack.c	Thu Jul 11 04:38:33 2019
> > 	(r349907)
> > @@ -1,5 +1,5 @@
> >  /*-
> > - * Copyright (c) 2016
> > + * Copyright (c) 2016-2019
> >   *	Netflix Inc.  All rights reserved.
> >   *
> >   * Redistribution and use in source and binary forms, with or without
> > @@ -8537,10 +8537,10 @@ out:
> >  	 * retransmit.  In persist state, just set snd_max.
> >  	 */
> >  	if (error == 0) {
> > -/*		if (TCPS_HAVEESTABLISHED(tp->t_state) &&
> > +		if (TCPS_HAVEESTABLISHED(tp->t_state) &&
> >  		    (tp->t_flags & TF_SACK_PERMIT) &&
> >  		    tp->rcv_numsacks > 0)
> > -		    tcp_clean_dsack_blocks(tp);*/
> > +			tcp_clean_dsack_blocks(tp);
> >  		if (len == 0)
> >  			counter_u64_add(rack_out_size[TCP_MSS_ACCT_SNDACK], 1);
> >  		else if (len == 1) {
> >
>
> This commit updates more than just the copyright. Were the other 
> changes intended? If yes,
>
> a) Removing the */ at the other end of the commented block is also 
> needed.

My mistake. I missed the */. Sorry.

> b) The commit log is incorrect.

This is still a problem.

>
> Let's revert this and try again.

For the sake of the log, probably.


-- 
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.