svn commit: r349423 - head/contrib/elftoolchain/elfcopy

[Roger Pau Monné]

On Wed, Jun 26, 2019 at 04:35:37PM +0000, Mark Johnston wrote:
> Author: markj
> Date: Wed Jun 26 16:35:37 2019
> New Revision: 349423
> URL: https://svnweb.freebsd.org/changeset/base/349423
> 
> Log:
>   elfcopy: Provide a size hint when creating the section string table.
>   
>   Use the input file's .shstrtab size as the hint if it exists.  This
>   gives a small performance improvement when processing files with
>   many sections.

This change breaks the Xen build using objcopy. I have a very simple
test case, pick the file from:

https://people.freebsd.org/~royger/buildid.ihex

Then do:

$ objcopy -I ihex -O binary buildid.ihex buildid.o
objcopy: elf_nextscn failed: Invalid argument

This used to work before this change, and now fails.

Thanks, Roger.