svn commit: r343620 - head/sys/net

John Baldwin jhb at FreeBSD.org
Thu Jan 31 21:35:38 UTC 2019


Author: jhb
Date: Thu Jan 31 21:35:37 2019
New Revision: 343620
URL: https://svnweb.freebsd.org/changeset/base/343620

Log:
  Don't set IFCAP_TXRTLMT during lagg_clone_create().
  
  lagg_capabilities() will set the capability once interfaces supporting
  the feature are added to the lagg.  Setting it on a lagg without any
  interfaces is pointless as the if_snd_tag_alloc call will always fail
  in that case.
  
  Reviewed by:	hselasky, gallatin
  MFC after:	2 weeks
  Sponsored by:	Netflix
  Differential Revision:	https://reviews.freebsd.org/D19040

Modified:
  head/sys/net/if_lagg.c

Modified: head/sys/net/if_lagg.c
==============================================================================
--- head/sys/net/if_lagg.c	Thu Jan 31 21:04:50 2019	(r343619)
+++ head/sys/net/if_lagg.c	Thu Jan 31 21:35:37 2019	(r343620)
@@ -514,10 +514,8 @@ lagg_clone_create(struct if_clone *ifc, int unit, cadd
 	ifp->if_flags = IFF_SIMPLEX | IFF_BROADCAST | IFF_MULTICAST;
 #ifdef RATELIMIT
 	ifp->if_snd_tag_alloc = lagg_snd_tag_alloc;
-	ifp->if_capenable = ifp->if_capabilities = IFCAP_HWSTATS | IFCAP_TXRTLMT;
-#else
-	ifp->if_capenable = ifp->if_capabilities = IFCAP_HWSTATS;
 #endif
+	ifp->if_capenable = ifp->if_capabilities = IFCAP_HWSTATS;
 
 	/*
 	 * Attach as an ordinary ethernet device, children will be attached


More information about the svn-src-all mailing list