svn commit: r343349 - head/sys/dev/ocs_fc

[Rodney W. Grimes]

> On Fri, Jan 25, 2019 at 7:44 AM Rodney W. Grimes
> <freebsd at pdx.rh.cn85.dnsmgr.net> wrote:
> >
> > > Hi Rodney,
> > >
> > > I fixed many coverity tool warnings as part of this commit. Adding all the
> > > warnings and fix details seemed over kill.
> >
> > It seems like overkill when your commiting, but if you have
> > have to go digging through commit history trying to find
> > something it helps a great deal to have good information
> > present there.
> >
> > You do not need to include the output from coverty,
> > but some amount of detail is very helpful.
> >
> 
> We do have a tendency to note CIDs in commit messages and that's pretty
> helpful -- I don't know that omitting them will generally ruffle any
> feathers, though.

yes, CIDs are fine, I should of clarified that, I would not
want to see the full output from  coverty in a commit message
unless it was needed to express what was fixed and why in
some way.


-- 
Rod Grimes                                                 rgrimes at freebsd.org