svn commit: r343118 - in head/usr.sbin: . trim

[Eugene Grosbein]

18.01.2019 4:45, Conrad Meyer wrote:

>>> Please back it out; stop attributing code review to "hackers@," which
>>> can not (it's a list, not individuals) and did not review this
>>> changeset; and put it on phabricator for actual review.
>>
>> There is already https://reviews.freebsd.org/D18380 by imp
>> and there were over 6 weeks since it had an update.
>> Newly committed code has most of its changes.
> 
> Your response does not address *any* of the above concerns.  It's just
> unrelated.
> 
> The review you linked to isn't one you submitted for this change;

This is a review still.

> it's Warner's, and that one stalled because you were such a jerk to him

This is not true.

> last time that he needed time off from you.

Please do not speak for him.

> If you want to socialize, revive, or expedite someone else's review,
> maybe add a new comment to the review,

I did.

> or post a discussion hackers@,

I did.

> or something like that.  You still can't attribute code review to
> hackers@, especially as no such review happened.

It happened a week before I make first commit, in a way. I cannot make people
do a review if they do not want to review. And we still had no utility to do the job.