svn commit: r343058 - in head/sys: compat/linuxkpi/common/src vm

Ian Lepore ian at freebsd.org
Tue Jan 15 20:20:28 UTC 2019


On Tue, 2019-01-15 at 12:06 -0800, Gleb Smirnoff wrote:
> On Tue, Jan 15, 2019 at 01:46:23PM -0600, Justin Hibbits wrote:
> J> Why not #include counter.h in the relevant vm_machdep.c files
> instead?
> 
> This also is ugly :( Not sure more or less. Probably less, but I
> urged to plug all possible compilation failures at a time.
> 
> What is ugly is that most files just need counter_u64_t size,
> and they don't use counter(9) KPI.
> 
> The fact that vm_machdep or Linux KPI want to look into internal
> type uma_zone_t is also ugly.
> 

Isn't the usual fix for this problem to create a __counter_u64_t in
sys/types.h and use it in places where including the full header file
is undesirable for some reason?

-- Ian



More information about the svn-src-all mailing list