svn commit: r342945 - in head: tools/build/mk usr.sbin/bluetooth usr.sbin/bluetooth/bluetooth-config

[Devin Teske]

> On Jan 11, 2019, at 10:36 AM, Rodney W. Grimes <freebsd at pdx.rh.CN85.dnsmgr.net> wrote:
> 
> [ Charset UTF-8 unsupported, converting... ]
>> On Fri, Jan 11, 2019 at 10:10 AM Rodney W. Grimes <
>> freebsd at pdx.rh.cn85.dnsmgr.net> wrote:
>> 
>>>> On Fri, Jan 11, 2019 at 08:04:33AM -0800, Rodney W. Grimes wrote:
>>>>> The style of this .sh does not match the normal style of
>>>>> such things in base, especially with respect to long lines
>>>>> and indentation.
>>>> 
>>>> Do we have a style guide for shell scripts in base? How should
>>>> indentation look like?
>>> 
>>> Not that I can locate, but I can state that almost all
>>> of the base code uses tab indenting and limited to 80
>>> column widths, independent of c, sh, make, etc.
>>> 
>> 
>> We have a style.Makefile, style, style.mdoc and style.lua man pages. Maybe
>> it's time for style.sh, eh?
> 
> Yes please!
> 

If we can agree to be professional and collegial, ...

I'll start with chapters from the Style section of my book:
https://freebsdfrau.gitbooks.io/serious-shell-programming/content/style/awk.html <https://freebsdfrau.gitbooks.io/serious-shell-programming/content/style/awk.html>

-- 
Devin