svn commit: r342865 - head/stand/i386/libfirewire

Warner Losh imp at FreeBSD.org
Tue Jan 8 20:01:58 UTC 2019


Author: imp
Date: Tue Jan  8 20:01:56 2019
New Revision: 342865
URL: https://svnweb.freebsd.org/changeset/base/342865

Log:
  biospci_write_config args were backwards
  
  biospci_write_config args swapped length and value to write. Some
  hardware coped just fine, while other hardware had issues.
  
  PR: 155441
  Submitted by: longwitz at incore dot de

Modified:
  head/stand/i386/libfirewire/firewire.c

Modified: head/stand/i386/libfirewire/firewire.c
==============================================================================
--- head/stand/i386/libfirewire/firewire.c	Tue Jan  8 17:21:59 2019	(r342864)
+++ head/stand/i386/libfirewire/firewire.c	Tue Jan  8 20:01:56 2019	(r342865)
@@ -107,9 +107,9 @@ fw_probe(int index, struct fwohci_softc *sc)
 	}
 
 	biospci_write_config(sc->locator,
-		0x4	/* command */,
-		0x6	/* enable bus master and memory mapped I/O */,
-		BIOSPCI_16BITS);
+	    0x4	/* command */,
+	    BIOSPCI_16BITS,
+	    0x6	/* enable bus master and memory mapped I/O */);
 
 	biospci_read_config(sc->locator, 0x00 /*devid*/, BIOSPCI_32BITS,
 		&sc->devid);


More information about the svn-src-all mailing list