svn commit: r344567 - in head: etc/mtree include sbin sbin/veriexec
danfe at freebsd.org
Tue Feb 26 17:23:59 UTC 2019
On Tue, Feb 26, 2019 at 09:12:11AM -0800, John Baldwin wrote:
> On 2/26/19 5:49 AM, Alexey Dokuchaev wrote:
> > On Mon, Feb 25, 2019 at 10:19:45PM -0800, Rodney W. Grimes wrote:
> >> ...
> >> Just a small nit, for future reference, from the template:
> >>> Differential Revision: https://reviews.freebsd.org/D###
> >> (*full* phabric URL needed).
> > IMHO we should just fix the scripts to accept D#### alone, without
> > the URL. We don't do that for PR (bugzilla) references, and the fact
> > that we do for the phab is both needless and confusing. Also, that
> > URL might change one day while we could probably keep the old numbers
> > if we move.
> It makes the review clickable in many mail clients which is very handy.
I understand that, but then again, we don't do that for PRs and people
don't seem to complain. Accepting D#### would make this all consistent
and commit messages cleaner. Arguably, if one likes to click the URLs
in their mail client, why not configure the client to expand the URL in
> John Baldwin
Can you do something about this horde of \x9a's appended to your every
More information about the svn-src-all