svn commit: r344129 - head

Enji Cooper yaneurabeya at
Fri Feb 15 17:22:32 UTC 2019

> On Feb 14, 2019, at 19:08, Warner Losh <imp at> wrote:
>> On Thu, Feb 14, 2019, 1:42 PM Rodney W. Grimes <freebsd at wrote:
>> > On Thu, Feb 14, 2019 at 12:00:22PM -0700, Warner Losh wrote:
>> > > On Thu, Feb 14, 2019 at 11:29 AM Rodney W. Grimes <
>> > > > >   Differential Review:
>> > > >
>> > > > You sited a differential, but not give any attribution
>> > > > to the external source :-(
>> > > >
>> > > 
>> > > The differential review has that information.
>> > 
>> > External contributors should be recognized by having their names appear
>> > in the commit logs.
>> We even bother to put a special line in the commit template
>> for this.  Further it has been standard operating procedure
>> for at least as long as I have been back that submitters
>> are infact recognized in commit messages.
>> You have, again, summarily dismissed valid feedback.
> The problem is that was a trivial commit. And you offered not one, but two complaints about adding an 'e' to the updating file. That's what pissed me off. It's advice that might be correct, but was so far over the top, in public, for such a trivial commit. That's why I got mad: it added no value and seemed nit picky and pretty. So I lost it. I shouldn't have, but I did. 
> I'm sorry for my cool.

Thank you both Rod and Warner for the reply.

Thank you Rod for noting that src-committers was a public list; I thought it was private to FreeBSD src committers.

I replied to this thread because while I agree with what you said, I felt that the reaction and forum were not in proportion to what happened :/.

More than a handful of threads lately have become heated to a point that concerns me about inter-developer relations and perception outside of the community. I have taken part in some of the discussions, potentially contributing to the overall issue.

I’m happy with the eventual outcome, but I hope that we, as a group, can do better next time to avoid these situations and be kinder to one another. Many of the recent issues (while important in aggregate) seem minor (in disaggregate).

All the best,

More information about the svn-src-all mailing list