svn commit: r344073 - stable/12/sys/cam/scsi

Alexander Motin mav at FreeBSD.org
Wed Feb 13 00:37:18 UTC 2019


Author: mav
Date: Wed Feb 13 00:37:16 2019
New Revision: 344073
URL: https://svnweb.freebsd.org/changeset/base/344073

Log:
  MFC r343582,r343588:Relax BIO_FLUSH ordering in da(4), respecting BIO_ORDERED.
  
  r212160 tightened this from always using MSG_SIMPLE_Q_TAG to always
  MSG_ORDERED_Q_TAG.  Since it also marked all BIO_FLUSH requests with
  BIO_ORDERED, this commit changes nothing immediately, but it returns
  BIO_FLUSH callers ability to actually specify ordering they really
  need, alike to other request types.

Modified:
  stable/12/sys/cam/scsi/scsi_da.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/cam/scsi/scsi_da.c
==============================================================================
--- stable/12/sys/cam/scsi/scsi_da.c	Wed Feb 13 00:35:09 2019	(r344072)
+++ stable/12/sys/cam/scsi/scsi_da.c	Wed Feb 13 00:37:16 2019	(r344073)
@@ -3258,14 +3258,12 @@ more:
 			/*
 			 * BIO_FLUSH doesn't currently communicate
 			 * range data, so we synchronize the cache
-			 * over the whole disk.  We also force
-			 * ordered tag semantics the flush applies
-			 * to all previously queued I/O.
+			 * over the whole disk.
 			 */
 			scsi_synchronize_cache(&start_ccb->csio,
 					       /*retries*/1,
 					       /*cbfcnp*/dadone,
-					       MSG_ORDERED_Q_TAG,
+					       /*tag_action*/tag_code,
 					       /*begin_lba*/0,
 					       /*lb_count*/0,
 					       SSD_FULL_SIZE,


More information about the svn-src-all mailing list