svn commit: r343925 - stable/12/sys/vm

Alexander Motin mav at
Sat Feb 9 02:09:30 UTC 2019

Author: mav
Date: Sat Feb  9 02:09:29 2019
New Revision: 343925

  MFC r343673: Fix integer math overflow in UMA hash_alloc().
  512GB of ZFS ABD ARC means abd_chunk zone of 128M 4KB items.  To manage
  them UMA tries to allocate 2GB hash table, which size does not fit into
  the int variable, causing later allocation failure, which makes ARC shrink
  back below the 512GB, not letting it to use more RAM.  With this change I
  easily reached >700GB ARC size on 768GB RAM machine.
  Sponsored by:	iXsystems, Inc.

Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/vm/uma_core.c
--- stable/12/sys/vm/uma_core.c	Sat Feb  9 02:04:27 2019	(r343924)
+++ stable/12/sys/vm/uma_core.c	Sat Feb  9 02:09:29 2019	(r343925)
@@ -631,7 +631,7 @@ static int
 hash_alloc(struct uma_hash *hash)
 	int oldsize;
-	int alloc;
+	size_t alloc;
 	oldsize = hash->uh_hashsize;

More information about the svn-src-all mailing list