svn commit: r355735 - in head/sys: arm/broadcom/bcm2835 arm/mv dev/ow

[Ravi Pokala]

Thanks!

-Ravi (rpokala@)

-----Original Message-----
From: <owner-src-committers at freebsd.org> on behalf of Warner Losh <imp at FreeBSD.org>
Date: 2019-12-13, Friday at 13:39
To: <src-committers at freebsd.org>, <svn-src-all at freebsd.org>, <svn-src-head at freebsd.org>
Subject: svn commit: r355735 - in head/sys: arm/broadcom/bcm2835 arm/mv dev/ow

    Author: imp
    Date: Fri Dec 13 21:39:20 2019
    New Revision: 355735
    URL: https://svnweb.freebsd.org/changeset/base/355735
    
    Log:
      Be consistent about checking return value from bus_delayed_attach_children.
      
      Most places checked, but a couple last minute changes didn't. Make them all use
      the return value.
      
      Noticed by: rpokala@
    
    Modified:
      head/sys/arm/broadcom/bcm2835/bcm2835_bsc.c
      head/sys/arm/mv/a37x0_spi.c
      head/sys/dev/ow/owc_gpiobus.c
    
    Modified: head/sys/arm/broadcom/bcm2835/bcm2835_bsc.c
    ==============================================================================
    --- head/sys/arm/broadcom/bcm2835/bcm2835_bsc.c	Fri Dec 13 21:39:10 2019	(r355734)
    +++ head/sys/arm/broadcom/bcm2835/bcm2835_bsc.c	Fri Dec 13 21:39:20 2019	(r355735)
    @@ -347,9 +347,7 @@ bcm_bsc_attach(device_t dev)
     	}
     
     	/* Probe and attach the iicbus when interrupts are available. */
    -	bus_delayed_attach_children(dev);
    -
    -	return (0);
    +	return (bus_delayed_attach_children(dev));
     }
     
     static int
    
    Modified: head/sys/arm/mv/a37x0_spi.c
    ==============================================================================
    --- head/sys/arm/mv/a37x0_spi.c	Fri Dec 13 21:39:10 2019	(r355734)
    +++ head/sys/arm/mv/a37x0_spi.c	Fri Dec 13 21:39:20 2019	(r355735)
    @@ -220,9 +220,7 @@ a37x0_spi_attach(device_t dev)
     	device_add_child(dev, "spibus", -1);
     
     	/* Probe and attach the spibus when interrupts are available. */
    -	bus_delayed_attach_children(dev);
    -
    -	return (0);
    +	return (bus_delayed_attach_children(dev));
     }
     
     static int
    
    Modified: head/sys/dev/ow/owc_gpiobus.c
    ==============================================================================
    --- head/sys/dev/ow/owc_gpiobus.c	Fri Dec 13 21:39:10 2019	(r355734)
    +++ head/sys/dev/ow/owc_gpiobus.c	Fri Dec 13 21:39:20 2019	(r355735)
    @@ -131,9 +131,7 @@ owc_gpiobus_attach(device_t dev)
     		free(kids, M_TEMP);
     	if (nkid == 0)
     		device_add_child(dev, "ow", -1);
    -	bus_delayed_attach_children(dev);
    -
    -	return (0);
    +	return (bus_delayed_attach_children(dev));
     }
     
     static int