svn commit: r355407 - head/sys/fs/tmpfs

Ian Lepore ian at freebsd.org
Thu Dec 5 18:16:04 UTC 2019


On Thu, 2019-12-05 at 10:05 -0800, Enji Cooper wrote:
> > On Dec 5, 2019, at 05:36, Konstantin Belousov <kostikbel at gmail.com>
> > wrote:
> 
> ...
> 
> > > Could you elaborate on the why/rationale?
> > > 
> > > Is there memory wastage/duplication, bug(s), performance or 
> > > development/maintenance benefit?
> > 
> > Each mount/unmount of tmpfs created and destroyed two zones, as it
> > is
> > easy to see from the patch.
> 
> Commit messages should provide helpful summaries of changes. Having
> to look at and understand the patch requires domain knowledge which
> the reader may or may not have. Kubilay’s request seems valid to me.
> 
> -Enji

I agree.  You read the diff to see the details of what changed.  You
read the commit message to see why.

-- Ian




More information about the svn-src-all mailing list