svn commit: r351471 - in head/sys: kern sys

Mateusz Guzik mjguzik at gmail.com
Fri Aug 30 22:03:11 UTC 2019


On 8/25/19, Oliver Pinter <oliver.pinter at hardenedbsd.org> wrote:
> On Sunday, August 25, 2019, Mateusz Guzik <mjg at freebsd.org> wrote:
>
>> Author: mjg
>> Date: Sun Aug 25 05:11:43 2019
>> New Revision: 351471
>> URL: https://svnweb.freebsd.org/changeset/base/351471
>>
>> Log:
>>   vfs: add vholdnz (for already held vnodes)
>
>
> Why?
>
> (Yes, is can read the real reason in phabricator, but the phabricator
> didn't considered a persistent information in relation to commit message.
> Review helper tool just comes and goes as time goes forward, but commit
> messages survives the repo conversions to other VCS...)
>
> And once you have taken the time to write a correct description in
> phabricator, it would be really really nice and helpful if you would copy
> them into commit message.
>

I think it's a fair point that if I included this info in the review it
should make it's way into the commit message.

-- 
Mateusz Guzik <mjguzik gmail.com>


More information about the svn-src-all mailing list