svn commit: r350512 - head/tests/sys/kern

[Li-Wen Hsu]

On Thu, Aug 8, 2019 at 4:27 AM Mark Johnston <markj at freebsd.org> wrote:
>
> On Thu, Aug 01, 2019 at 06:19:16PM +0000, Li-Wen Hsu wrote:
> > Author: lwhsu
> > Date: Thu Aug  1 18:19:16 2019
> > New Revision: 350512
> > URL: https://svnweb.freebsd.org/changeset/base/350512
> >
> > Log:
> >   Only skip test cases sometimes failing in CI when they are running in CI
> >
> >   Suggested by:       jhb
> >   Sponsored by:       The FreeBSD Foundation
>
> This seems to break running the tests manually; atf dies because the
> "ci" variable is not defined.  I have to use an invocation like this to
> avoid that:
>
> $ kyua -v test_suites.FreeBSD.ci=false test ptrace_test
>
> I suspect that share/mk/suite.test.mk needs to be augmented somehow to
> set this variable to "false" by default, so that the CI infrastructure
> can override that.

Thanks for catching this!  I feel that the better approach is using
function that gets this variable with default value, for keeping
things simple.

Best,
Li-Wen