svn commit: r350550 - head/share/mk

[Glen Barber]

On Sat, Aug 03, 2019 at 01:06:18AM +0000, John Baldwin wrote:
> Author: jhb
> Date: Sat Aug  3 01:06:17 2019
> New Revision: 350550
> URL: https://svnweb.freebsd.org/changeset/base/350550
> 
> Log:
>   Flip REPRODUCIBLE_BUILD back to off by default in head.
>   
>   Having the full uname output can be useful on head even with
>   unmodified trees or trees that newvers.sh fails to recognize as
>   modified.
>   
>   Reviewed by:	emaste
>   Differential Revision:	https://reviews.freebsd.org/D20895
> 

I would like to request this commit be reverted.  While the original
commit message to enable this knob stated the commit would be reverted
after stable/12 branched, I have seen no public complaints about
enabling REPRODUCIBLE_BUILD by default (and quite honestly, do not see
the benefit of disabling it by default -- why wouldn't we want
reproducibility?).

To me, this feels like a step backwards, with no tangible benefit.
Note, newvers.sh does properly detect a modified tree if it can find
the VCS metadata directory (i.e., .git, .svn) -- I know this because
I personally helped with it.

In my opinion, those that want the non-reproducible metadata included in
output from 'uname -a' should set WITHOUT_REPRODUCIBLE_BUILDS in their
src.conf.  Turning off a sane default for the benefit of what I suspect
is likely a short list of use cases feels like a step in the wrong
direction.

Glen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20190806/e7fbc1ba/attachment.sig>