svn commit: r346932 - head/sys/ufs/ufs

Alexey Dokuchaev danfe at freebsd.org
Tue Apr 30 06:08:50 UTC 2019


On Mon, Apr 29, 2019 at 10:05:26PM +0000, Mark Johnston wrote:
> New Revision: 346932
> URL: https://svnweb.freebsd.org/changeset/base/346932
> 
> Log:
>   Optimize lseek(SEEK_DATA) on UFS.
>   
>   This version fixes the problems identified in r345244.
>   
>   Reviewed by:	kib
> @@ -56,6 +56,9 @@ __FBSDID("$FreeBSD$");
>  #include <ufs/ufs/ufsmount.h>
>  #include <ufs/ufs/ufs_extern.h>
>  
> +static ufs_lbn_t lbn_count(struct ufsmount *, int);
> +static int readindir(struct vnode *, ufs_lbn_t, ufs2_daddr_t, struct buf **);

Is the prototype for static readindir() really needed here?

> +static int
> +readindir(vp, lbn, daddr, bpp)
> +	struct vnode *vp;
> +	ufs_lbn_t lbn;
> +	ufs2_daddr_t daddr;
> +	struct buf **bpp;

Don't we prefer ASNI declarations over K&R these days?

> +static ufs_lbn_t
> +lbn_count(ump, level)
> +	struct ufsmount *ump;
> +	int level;

Ditto.

> +int
> +ufs_bmap_seekdata(vp, offp)
> +	struct vnode *vp;
> +	off_t *offp;

./danfe


More information about the svn-src-all mailing list