svn commit: r346916 - stable/11/sys/dev/cxgbe

Navdeep Parhar np at FreeBSD.org
Mon Apr 29 19:25:20 UTC 2019


Author: np
Date: Mon Apr 29 19:25:06 2019
New Revision: 346916
URL: https://svnweb.freebsd.org/changeset/base/346916

Log:
  MFC r338940:
  
  cxgbe(4): Treat base/end of firmware parameters as signed integers when
  figuring out whether the range is valid or not.

Modified:
  stable/11/sys/dev/cxgbe/t4_main.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/dev/cxgbe/t4_main.c
==============================================================================
--- stable/11/sys/dev/cxgbe/t4_main.c	Mon Apr 29 19:23:27 2019	(r346915)
+++ stable/11/sys/dev/cxgbe/t4_main.c	Mon Apr 29 19:25:06 2019	(r346916)
@@ -3917,7 +3917,7 @@ get_params__post_init(struct adapter *sc)
 
 	sc->sge.iq_start = val[0];
 	sc->sge.eq_start = val[1];
-	if (val[3] > val[2]) {
+	if ((int)val[3] > (int)val[2]) {
 		sc->tids.ftid_base = val[2];
 		sc->tids.ftid_end = val[3];
 		sc->tids.nftids = val[3] - val[2] + 1;
@@ -4052,7 +4052,7 @@ get_params__post_init(struct adapter *sc)
 			    "failed to query NIC parameters: %d.\n", rc);
 			return (rc);
 		}
-		if (val[1] > val[0]) {
+		if ((int)val[1] > (int)val[0]) {
 			sc->tids.etid_base = val[0];
 			sc->tids.etid_end = val[1];
 			sc->tids.netids = val[1] - val[0] + 1;
@@ -4082,7 +4082,7 @@ get_params__post_init(struct adapter *sc)
 			sc->tids.ntids -= sc->tids.nhpftids;
 		}
 		sc->tids.natids = min(sc->tids.ntids / 2, MAX_ATIDS);
-		if (val[2] > val[1]) {
+		if ((int)val[2] > (int)val[1]) {
 			sc->tids.stid_base = val[1];
 			sc->tids.nstids = val[2] - val[1] + 1;
 		}


More information about the svn-src-all mailing list