svn commit: r346688 - head/sys/net

Kyle Evans kevans at freebsd.org
Thu Apr 25 18:27:21 UTC 2019


On Thu, Apr 25, 2019 at 1:24 PM Rodney W. Grimes
<freebsd at gndrsh.dnsmgr.net> wrote:
>
> [ Charset UTF-8 unsupported, converting... ]
> > Author: kevans
> > Date: Thu Apr 25 18:22:22 2019
> > New Revision: 346688
> > URL: https://svnweb.freebsd.org/changeset/base/346688
> >
> > Log:
> >   tap(4): Add a MODULE_VERSION
>     ^^^
> >
> >   Otherwise tap(4) can be loaded by loader despite being compiled into the
> >   kernel, causing a panic as things try to double-initialize.
> >
> >   PR:         220867
> >   MFC after:  3 days
> >
> > Modified:
> >   head/sys/net/if_tap.c
>                     ^^^
> >
> > Modified: head/sys/net/if_tap.c
> > ==============================================================================
> > --- head/sys/net/if_tap.c     Thu Apr 25 18:13:55 2019        (r346687)
> > +++ head/sys/net/if_tap.c     Thu Apr 25 18:22:22 2019        (r346688)
> > @@ -180,6 +180,7 @@ SYSCTL_INT(_net_link_tap, OID_AUTO, devfs_cloning, CTL
> >  SYSCTL_INT(_net_link_tap, OID_AUTO, debug, CTLFLAG_RW, &tapdebug, 0, "");
> >
> >  DEV_MODULE(if_tap, tapmodevent, NULL);
>                  ^^^
> > +MODULE_VERSION(if_tun, 1);
>                      ^^^
> If wrong, ok, please fix, if correct, please this needs a very
> complete comment as to what it is if_tun.
>

*sigh*

I had one job to do, and I goofed it. Thanks for pointing that out...

Kyle Evans


More information about the svn-src-all mailing list