svn commit: r346341 - head/tools/build

[Rodney W. Grimes]

> Author: cy
> Date: Thu Apr 18 01:02:00 2019
> New Revision: 346341
> URL: https://svnweb.freebsd.org/changeset/base/346341
> 
> Log:
>   As an interim measure until a more permanent solution is implemented
>   workaround the following error:
>   
>   /usr/src/contrib/elftoolchain/strings/strings.c:198:55: error: use of
>   undeclared identifier
>   'FA_OPEN' fa = fileargs_init(argc, argv, O_RDONLY, 0, &rights, FA_OPEN);
>   
>   Reported by:	O. Hartmann <ohartmann at walstatt.org>
>   Reported by:	Michael Butler <imb at protected-networks.net>
>   Reported by:	gjb@ & cy@ (implicit)
>   Reviewed by:	emaste@
>   Noted by:	rgrimes@
> 
> Modified:
>   head/tools/build/Makefile
> 
> Modified: head/tools/build/Makefile
> ==============================================================================
> --- head/tools/build/Makefile	Thu Apr 18 00:38:54 2019	(r346340)
> +++ head/tools/build/Makefile	Thu Apr 18 01:02:00 2019	(r346341)
> @@ -59,9 +59,7 @@ INCS+=		capsicum_helpers.h
>  INCS+=		libcasper.h
>  .endif
>  
> -.if !exists(/usr/include/casper/cap_fileargs.h)
>  CASPERINC+=	${SRCTOP}/lib/libcasper/services/cap_fileargs/cap_fileargs.h
> -.endif

As a further note, we should probably hunt for any thing
that is explicity looking at /usr/include/... in a Makefile,
as that is minimally missing a ${DESTDIR} argument.

The above may of actually worked if it had been written:
.if !exists(${DESTDIR}/usr/include/casper/cap_fileargs.h)
someone may wish to test that.

Also a pathname rooted at / without ${DESTDIR} is almost certainly a mistake.

>  .if empty(SRCS)
>  SRCS=		dummy.c

-- 
Rod Grimes                                                 rgrimes at freebsd.org