svn commit: r346017 - in head: libexec/rc libexec/rc/rc.d share/man/man5

Rodney W. Grimes freebsd at gndrsh.dnsmgr.net
Tue Apr 9 18:38:08 UTC 2019


> Hey,
> 
> On 9 April 2019 14:13:54 BST, "O. Hartmann" <ohartmann at walstatt.org> wrote:
> >On Sun, 7 Apr 2019 18:31:45 +0000 (UTC)
> >Chris Rees <crees at FreeBSD.org> wrote:
> >
> >> Author: crees (doc,ports committer)
> >> Date: Sun Apr  7 18:31:45 2019
> >> New Revision: 346017
> >> URL: https://svnweb.freebsd.org/changeset/base/346017
> >>
> >> Log:
> >>   Remove now unnecessary kldstat check before attempting to load
> >modules.
> >>
> >>   Since r233109, kldload has the -n option, which silently ignores
> >options
> >>   that are already loaded.
> >>
> >>  
> >https://lists.freebsd.org/pipermail/freebsd-rc/2018-December/003899.html
> >>
> >>   Note that this script no longer reports if the module is already
> >loaded,
> >>   but it could be argued this wasn't particularly useful information.
> >>
> >>   PR:			docs/234248
> >>   Reviewed by:		bcr (docs), kib, rgrimes (visual)
> >>   Approved by:		jilles
> >>   Differential Revision:	https://reviews.freebsd.org/D18670
> >>
> >> Modified:
> >>   head/libexec/rc/rc.d/abi
> >>   head/libexec/rc/rc.d/bthidd
> >>   head/libexec/rc/rc.d/cfumass
> >>   head/libexec/rc/rc.d/kld
> >>   head/libexec/rc/rc.d/mdconfig
> >>   head/libexec/rc/rc.d/mdconfig2
> >>   head/libexec/rc/rc.d/mountcritremote
> >>   head/libexec/rc/rc.d/syscons
> >>   head/libexec/rc/rc.subr
> >>   head/share/man/man5/rc.conf.5
> >>
> >> Modified: head/libexec/rc/rc.d/abi
> >>
> >==============================================================================
> 
> 
> {Snip}
> 
> 
> >It seems this patch breaks ZFS if ZFS is built-in kernel!
> >
> >Having ZFS as kernel built-in leaves the system not mounting ANY(!) ZFS
> >volume
> >at boot time, rendering servers unusable.
> >Mounting ZFS filesystems with "zfs mount -a" bring back the ZFS
> >filesystems as
> >expected.
> >
> 
> Are you sure it's this causing that?  Please try reverting it.

I think the trigger issue is:
grep zfs /etc/rc.d/zvol 
rcvar="zfs_enable"
required_modules="zfs"

that module requires may be going south with the
new code when the module is built into the kernel.

> Chris 
-- 
Rod Grimes                                                 rgrimes at freebsd.org


More information about the svn-src-all mailing list