svn commit: r345900 - head/sbin/fsck_msdosfs

Rodney W. Grimes freebsd at gndrsh.dnsmgr.net
Fri Apr 5 04:49:36 UTC 2019


> Author: delphij
> Date: Fri Apr  5 02:21:16 2019
> New Revision: 345900
> URL: https://svnweb.freebsd.org/changeset/base/345900
> 
> Log:
>   Implement checking of `.' and `..' entries of subdirectory.
>   
>   Reviewed by:		pfg
>   Obtained from:		Android https://android.googlesource.com/platform/external/fsck_msdos/+/b6ee08aadb580341a4d80943741b80de16a88b5d%5E%21/
>   MFC after:		2 weeks
>   Differential Revision:	https://reviews.freebsd.org/D19824
> 
> Modified:
>   head/sbin/fsck_msdosfs/dir.c
> 
> Modified: head/sbin/fsck_msdosfs/dir.c
> ==============================================================================
> --- head/sbin/fsck_msdosfs/dir.c	Fri Apr  5 01:22:30 2019	(r345899)
> +++ head/sbin/fsck_msdosfs/dir.c	Fri Apr  5 02:21:16 2019	(r345900)
> @@ -444,7 +444,78 @@ checksize(struct bootblock *boot, struct fatEntry *fat
>  	return FSOK;
>  }
>  
> +static const u_char dot_name[] = {
> +	'.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> +static const u_char dotdot_name[] = {
> +	'.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> +

Does it make since to encode these as hex or octal constants,
one can not tell that those are different values in an easy
manner.  They all look like '.' in the diff, and probably
in most editors.

>  /*
...

-- 
Rod Grimes                                                 rgrimes at freebsd.org


More information about the svn-src-all mailing list