svn commit: r338984 - stable/10/sys/kern

[Gordon Tetlow]

Author: gordon
Date: Thu Sep 27 18:44:40 2018
New Revision: 338984
URL: https://svnweb.freebsd.org/changeset/base/338984

Log:
  MFC r338982.
  
  Clear stack allocated data structure to prevent kernel memory leak.
  
  Reported by:	Thomas Barabosch, Fraunhofer FKIE
  Reviewed by:	wes@
  Approved by:	so
  Security:	FreeBSD-EN-18:12.mem
  Security:	CVE-2018-17155

Modified:
  stable/10/sys/kern/kern_context.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/kern/kern_context.c
==============================================================================
--- stable/10/sys/kern/kern_context.c	Thu Sep 27 18:42:40 2018	(r338983)
+++ stable/10/sys/kern/kern_context.c	Thu Sep 27 18:44:40 2018	(r338984)
@@ -68,6 +68,7 @@ sys_getcontext(struct thread *td, struct getcontext_ar
 	if (uap->ucp == NULL)
 		ret = EINVAL;
 	else {
+		bzero(&uc, sizeof(ucontext_t));
 		get_mcontext(td, &uc.uc_mcontext, GET_MC_CLEAR_RET);
 		PROC_LOCK(td->td_proc);
 		uc.uc_sigmask = td->td_sigmask;
@@ -108,6 +109,7 @@ sys_swapcontext(struct thread *td, struct swapcontext_
 	if (uap->oucp == NULL || uap->ucp == NULL)
 		ret = EINVAL;
 	else {
+		bzero(&uc, sizeof(ucontext_t));
 		get_mcontext(td, &uc.uc_mcontext, GET_MC_CLEAR_RET);
 		bzero(uc.__spare__, sizeof(uc.__spare__));
 		PROC_LOCK(td->td_proc);