svn commit: r338639 - head/sbin/umount

Mateusz Guzik mjg at FreeBSD.org
Thu Sep 13 13:57:43 UTC 2018


Author: mjg
Date: Thu Sep 13 13:57:42 2018
New Revision: 338639
URL: https://svnweb.freebsd.org/changeset/base/338639

Log:
  umount: remove sync(2) call when used with -f
  
  It completely unnecessarily iterates over all filesystems and happens
  to be executed a lot e.g. by synth.
  
  Reviewed by:	kib
  Approved by:	re (gjb)
  Differential Revision:	https://reviews.freebsd.org/D17143

Modified:
  head/sbin/umount/umount.c

Modified: head/sbin/umount/umount.c
==============================================================================
--- head/sbin/umount/umount.c	Thu Sep 13 10:18:50 2018	(r338638)
+++ head/sbin/umount/umount.c	Thu Sep 13 13:57:42 2018	(r338639)
@@ -136,10 +136,6 @@ main(int argc, char *argv[])
 	if ((fflag & MNT_FORCE) != 0 && (fflag & MNT_NONBUSY) != 0)
 		err(1, "-f and -n are mutually exclusive");
 
-	/* Start disks transferring immediately. */
-	if ((fflag & (MNT_FORCE | MNT_NONBUSY)) == 0 && nfsforce == 0)
-		sync();
-
 	if ((argc == 0 && !all) || (argc != 0 && all))
 		usage();
 


More information about the svn-src-all mailing list