svn commit: r339826 - in head: sys/amd64/vmm/intel usr.sbin/bhyve

[Yuri Pankov]

John Baldwin wrote:
> On 10/27/18 2:24 PM, Yuri Pankov wrote:
>> Author: yuripv
>> Date: Sat Oct 27 21:24:28 2018
>> New Revision: 339826
>> URL: https://svnweb.freebsd.org/changeset/base/339826
>>
>> Log:
>>   Provide basic descriptions for VMX exit reason (from "Intel 64 and IA-32
>>   Architectures Software Developer’s Manual Volume 3").  Add the document
>>   to SEE ALSO in bhyve.8 (and pet manlint here a bit).
>>   
>>   Reviewed by:	jhb, rgrimes, 0mp
>>   Approved by:	kib (mentor)
>>   Differential Revision:	https://reviews.freebsd.org/D17531
> 
> I did ask you to commit the bhyve.8 style fixes separately from the content
> changes in the review.  While it is true we don't currently have active
> translations of manpages, it is still a good practice to follow to not mix
> style changes with content changes even in code commits as it obfuscates
> the content changes.

Understood, will do.  I just (incorrectly) assumed your review approval
to be "go ahead with this one, but next time don't mix content changes
and cleanups", sorry about that.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20181029/637d6602/attachment.sig>