svn commit: r339581 - head/sys/dev/sound/midi

Hans Petter Selasky hselasky at FreeBSD.org
Mon Oct 22 08:55:59 UTC 2018


Author: hselasky
Date: Mon Oct 22 08:55:58 2018
New Revision: 339581
URL: https://svnweb.freebsd.org/changeset/base/339581

Log:
  Fix off-by-one which can lead to panics.
  
  Found by:		Peter Holm <peter at holm.cc>
  MFC after:		3 days
  Sponsored by:		Mellanox Technologies

Modified:
  head/sys/dev/sound/midi/sequencer.c

Modified: head/sys/dev/sound/midi/sequencer.c
==============================================================================
--- head/sys/dev/sound/midi/sequencer.c	Mon Oct 22 07:04:44 2018	(r339580)
+++ head/sys/dev/sound/midi/sequencer.c	Mon Oct 22 08:55:58 2018	(r339581)
@@ -730,7 +730,7 @@ static int
 seq_fetch_mid(struct seq_softc *scp, int unit, kobj_t *md)
 {
 
-	if (unit > scp->midi_number || unit < 0)
+	if (unit >= scp->midi_number || unit < 0)
 		return EINVAL;
 
 	*md = scp->midis[unit];


More information about the svn-src-all mailing list