svn commit: r339301 - head/share/mk

[Nathan Whitehorn]

Author: nwhitehorn
Date: Thu Oct 11 00:54:39 2018
New Revision: 339301
URL: https://svnweb.freebsd.org/changeset/base/339301

Log:
  Loader GELI support, like lua loader, seems to be broken on PowerPC as
  well as on SPARC64 and can cause boot failures even when no encrypted
  disks are present. Presumably, the reasons, while unknown, are the same
  and most-likely are the result of some endian-unsafe code. Pending
  finding the actual problem, extend the blacklist entry for these parts
  of loader on SPARC to also cover all PowerPC platforms.
  
  Approved by:	re (kib)

Modified:
  head/share/mk/src.opts.mk

Modified: head/share/mk/src.opts.mk
==============================================================================
--- head/share/mk/src.opts.mk	Thu Oct 11 00:26:15 2018	(r339300)
+++ head/share/mk/src.opts.mk	Thu Oct 11 00:54:39 2018	(r339301)
@@ -353,15 +353,12 @@ BROKEN_OPTIONS+=LOADER_OFW
 .if ${__T:Marm*} == "" && ${__T:Mmips*} == "" && ${__T:Mpowerpc*} == ""
 BROKEN_OPTIONS+=LOADER_UBOOT
 .endif
-# GELI and Lua in loader currently cause boot failures on sparc64.
-# Further debugging is required.
-.if ${__T} == "sparc64"
+# GELI and Lua in loader currently cause boot failures on sparc64 and powerpc.
+# Further debugging is required -- probably they are just broken on big
+# endian systems generically (they jump to null pointers or try to read
+# crazy high addresses, which is typical of endianness problems).
+.if ${__T} == "sparc64" || ${__T:Mpowerpc*}
 BROKEN_OPTIONS+=LOADER_GELI LOADER_LUA
-.endif
-# Lua in loader currently cause boot failures on powerpc.
-# Further debugging is required.
-.if ${__T} == "powerpc" || ${__T} == "powerpc64"
-BROKEN_OPTIONS+=LOADER_LUA
 .endif
 
 .if ${__T:Mmips64*}