svn commit: r339251 - in head/sys: net netinet netinet6

John Baldwin jhb at FreeBSD.org
Tue Oct 9 15:02:38 UTC 2018


On 10/9/18 6:26 AM, Jonathan T. Looney wrote:
> Author: jtl
> Date: Tue Oct  9 13:26:06 2018
> New Revision: 339251
> URL: https://svnweb.freebsd.org/changeset/base/339251
> 
> Log:
>   There are three places where we return from a function which entered an
>   epoch section without exiting that epoch section. This is bad for two
>   reasons: the epoch section won't exit, and we will leave the epoch tracker
>   from the stack on the epoch list.
>   
>   Fix the epoch leak by making sure we exit epoch sections before returning.

Do we have some sort of simple per-thread epoch counter similar to
td->td_locks that we could assert on in userret() and in the ithread loop
when ithreads go to sleep to help catch leaked locks?

-- 
John Baldwin

                                                                            


More information about the svn-src-all mailing list