svn commit: r335584 - head/sys/crypto/aesni

Conrad Meyer cem at freebsd.org
Sat Oct 6 23:03:37 UTC 2018


Sure, I don't have any objection.
On Mon, Oct 1, 2018 at 8:48 AM Alan Somers <asomers at freebsd.org> wrote:
>
> On Sat, Jun 23, 2018 at 12:20 PM Conrad Meyer <cem at freebsd.org> wrote:
>>
>> Author: cem
>> Date: Sat Jun 23 18:20:17 2018
>> New Revision: 335584
>> URL: https://svnweb.freebsd.org/changeset/base/335584
>>
>> Log:
>>   aesni(4): Fix {de,en}crypt operations that allocated a buffer
>>
>>   aesni(4) allocates a contiguous buffer for the data it processes if the
>>   provided input was not already virtually contiguous, and copies the input
>>   there.  It performs encryption or decryption in-place.
>>
>>   r324037 removed the logic that then copied the processed data back to the
>>   user-provided input buffer, breaking {de,enc}crypt for mbuf chains or
>>   iovecs with more than a single descriptor.
>>
>>   PR:           228094 (probably, not confirmed)
>>   Submitted by: Sean Fagan <kithrup AT me.com>
>>   Reported by:  Emeric POUPON <emeric.poupon AT stormshield.eu>
>>   X-MFC-With:   324037
>>   Security:     could result in plaintext being output by "encrypt"
>>                 operation
>>
>> Modified:
>>   head/sys/crypto/aesni/aesni.c
>
>
> Can we MFC this now?


More information about the svn-src-all mailing list