svn commit: r339124 - head/sys/x86/x86

Mark Johnston markj at FreeBSD.org
Wed Oct 3 14:20:44 UTC 2018


Author: markj
Date: Wed Oct  3 14:20:43 2018
New Revision: 339124
URL: https://svnweb.freebsd.org/changeset/base/339124

Log:
  Fix an inverted test in ucode_load_ap().
  
  This caused microcode to be updated only on the BSP if hyperthreading
  was disabled, typically resulting in a hang or reset.
  
  Approved by:	re (kib)
  Sponsored by:	The FreeBSD Foundation

Modified:
  head/sys/x86/x86/ucode.c

Modified: head/sys/x86/x86/ucode.c
==============================================================================
--- head/sys/x86/x86/ucode.c	Wed Oct  3 12:47:54 2018	(r339123)
+++ head/sys/x86/x86/ucode.c	Wed Oct  3 14:20:43 2018	(r339124)
@@ -269,7 +269,7 @@ ucode_load_ap(int cpu)
 	KASSERT(cpu_info[cpu_apic_ids[cpu]].cpu_present,
 	    ("cpu %d not present", cpu));
 
-	if (!cpu_info[cpu_apic_ids[cpu]].cpu_hyperthread)
+	if (cpu_info[cpu_apic_ids[cpu]].cpu_hyperthread)
 		return;
 #endif
 


More information about the svn-src-all mailing list