svn commit: r340722 - head/lib/libbe

[Mateusz Piotrowski]

Hello,

On Wed, 21 Nov 2018 at 17:54, Rodney W. Grimes <
freebsd at pdx.rh.cn85.dnsmgr.net> wrote:

> > On Wed, Nov 21, 2018 at 10:19 AM Rodney W. Grimes
> > <freebsd at pdx.rh.cn85.dnsmgr.net> wrote:
> > >
> > > > Author: 0mp (ports committer)
> > > > Date: Wed Nov 21 11:22:44 2018
> > > > New Revision: 340722
> > > > URL: https://svnweb.freebsd.org/changeset/base/340722
> > > >
> > > > Log:
> > > >   libbe(3): Put each error value in separate line.
> > > >
> > > >   As requested by a TODO in the source code.
> > > >
> > > >   Reviewed by:        bcr
> > > >   Approved by:        krion (mentor, implicit), mat (mentor,
> implicit)
> > > >   Differential Revision:      https://reviews.freebsd.org/D18063
> > >
> > > Who with a src bit approved the commit to src?
> > >
> >
> > I do want to clarify- bcr approved it in the review (explicitly with
> > "... hereby approved!") -- are you mainly pointing out that he failed
> > to annotate this properly in the commit, or is doc bit approval for a
> > commit to a manpage in src insufficient?
>
> That is defanitly a bit of a grey area, from reading and re-reading
> the commit bit page it is clear that a doc committer can commit
> to src documentation, it is not clear if they can approve a commit
> by someone else to the src tree, it does say
>         ""Approved by" from a non-mentored committer
>          with the appropriate bit"
>
> It probably would be fine to have said Approved by: bcr.
>

True. Perhaps as a ports committer I should even write
"Approved by: bcr (doc)" to make it clear that I collected
appropriate approvals before committing. I've been committing
small patches to the src tree for a couple of months now and
I've heard that "Reviewed by: bcr" is sufficient.

I guess that now I understand that "Reviewed by" is for listing
people and teams who reviewed the code and "Approved by" is
for listing all the necessary approvals one has to collect in
order to commit.

I still question what a out of scope commit that is
> approved by: (mentor, implicit).  I am not even sure
> what that means in this context.  Have his mentors
> said he can commit anything anyplace without them
> seeing it?  If so then release the mentor/mentee bit
> would be more appropriate?
>

mat@ and krion@ told me that I don't have to ask them about
explicit approval before committing to doc or src. If I gather
all the necessary approvals from doc and src committers then
I am able to commit with an implicit approval from my mentors.



> > As an aside, happy to approve any changes to these manpages as the
> > current bectl/libbe maintainer for anyone that wants to improve them.
> > =)
>

I'm really sorry, this is my fault. Usually, I request people,
who recently contributed to a certain part of a tree or who are listed
in the MAINTAINERS file, to review my changes. This time it was only
meant to be a small improvement to our documentation without any actual
content changes to the manual page itself so I only notified bcr.

Regards,
Mateusz