svn commit: r339898 - head/lib/libc/amd64/sys

[Shawn Webb]

On Tue, Oct 30, 2018 at 12:11:30AM +0000, Konstantin Belousov wrote:
> Author: kib
> Date: Tue Oct 30 00:11:30 2018
> New Revision: 339898
> URL: https://svnweb.freebsd.org/changeset/base/339898
> 
> Log:
>   Convert amd64_get/set_fs/gsbase to ifunc.
>   
>   Note that this is the first use of ifuncs in our userspace.

Hey Kostik,

It appears this commit broke building/linking libc with LTO. I'm
running into this assertion from clang/lld 7.0.0 (from the
projects/clang700-import feature branch):
https://github.com/HardenedBSD/hardenedBSD-playground/blob/hardened/current/cross-dso-cfi/contrib/llvm/include/llvm/Support/Casting.h#L255

I'm likely going to file a bug report upstream in llvm. I'm wondering
if lld doesn't support mixing ifuncs and LTO.

Thanks,

-- 
Shawn Webb
Cofounder and Security Engineer
HardenedBSD

Tor-ified Signal:    +1 443-546-8752
Tor+XMPP+OTR:        lattera at is.a.hacker.sx
GPG Key ID:          0x6A84658F52456EEE
GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89  3D9E 6A84 658F 5245 6EEE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20181120/8c9ea88c/attachment.sig>